Skip to content

Dynamically load certificates based on config#7863

Closed
zachmargolis wants to merge 2 commits intomainfrom
margolis-dynamic-artifact-store
Closed

Dynamically load certificates based on config#7863
zachmargolis wants to merge 2 commits intomainfrom
margolis-dynamic-artifact-store

Conversation

@zachmargolis
Copy link
Copy Markdown
Contributor

changelog: Internal, Certificates, Add dynamic code to rotate SAML certificates

Slightly more dynamic, error prone in a differen way, version of #7862

changelog: Internal, Certificates, Add dynamic code to rotate SAML certificates
@zachmargolis zachmargolis requested review from a team, bleachbyte and jmhooper February 21, 2023 19:24
Copy link
Copy Markdown
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread config/initializers/app_artifacts.rb Outdated
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
@zachmargolis
Copy link
Copy Markdown
Contributor Author

Going to close this for now, we can always revisit later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants